Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Do not perform destructive state ops when answering 'no' in prompt #8115

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix(cli): Do not perform destructive state ops when answering 'no' in prompt #8115

merged 1 commit into from
Sep 7, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

Closes #8114

@edgarrmondragon edgarrmondragon linked an issue Sep 7, 2023 that may be closed by this pull request
bug: State cleared when answering 'no' to confirmation prompt #8114
Closed
@netlify
Copy link

netlify bot commented Sep 7, 2023 •
edited

✅ Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit 5f808dd
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/64f916639caa340008281d9b

@ReubenFrankel ReubenFrankel mentioned this pull request Sep 7, 2023
Closed
@ReubenFrankel
Copy link
Contributor

My bad! 😅 😅 😅

@ReubenFrankel
Copy link
Contributor

You probably noticed, but this actually affected set, copy and move too.

@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited

Codecov Report

Merging #8115 (5f808dd) into main (4238e2b) will increase coverage by 0.03%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8115      +/-   ##
==========================================
+ Coverage   90.75%   90.79%   +0.03%     
==========================================
  Files         244      244              
  Lines       19077    19088      +11     
  Branches     2156     2158       +2     
==========================================
+ Hits        17314    17330      +16     
+ Misses       1434     1431       -3     
+ Partials      329      327       -2
Files Changed Coverage Δ
src/meltano/cli/state.py 90.71% <100.00%> (+1.42%) ⬆️
tests/meltano/cli/test_state.py 98.58% <100.00%> (+0.12%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon changed the title fix: Do not clear state when answering 'no' in prompt fix: Do not perform destructive state ops when answering 'no' in prompt Sep 7, 2023
@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 7, 2023 00:47
@edgarrmondragon edgarrmondragon changed the title fix: Do not perform destructive state ops when answering 'no' in prompt fix(cli): Do not perform destructive state ops when answering 'no' in prompt Sep 7, 2023
@edgarrmondragon edgarrmondragon merged commit 9c1542e into main Sep 7, 2023
44 checks passed
@edgarrmondragon edgarrmondragon deleted the 8114-bug-state-cleared-when-answering-no-to-confirmation-prompt branch September 7, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillDaSilva WillDaSilva WillDaSilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: State cleared when answering 'no' to confirmation prompt
3 participants
@edgarrmondragon @ReubenFrankel @WillDaSilva