docs: Use tabs for examples on settings page #8201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Settings are split by the following where appropriate: - meltano init - meltano config - export (environment variable) - meltano command
mjsqu
requested review from
sbalnojan,
tayloramurphy and
a team
as code owners
✅ Deploy Preview for meltano canceled.
|
E.g. if you click on 'env' all tabs on the page shift to 'env' - helpful if you have chosen one config style and want to stick to it for all settings/config
|
A couple of (optional) extras:
|
tayloramurphy
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Love this change! @cjohnhanson or @leoroese would either of you mind reviewing the CSS?
|
@mjsqu I'm fine with the color as-is. I like the idea of the querystring param change though. Feel free to add that 👍 thanks for the PR! |
edgarrmondragon
changed the title
edgarrmondragon
added
Documentation
leoroese
approved these changes
Oct 3, 2023
@tayloramurphy That's already done, with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Settings page in line with my previous change (#7765) for the Plugins page, adding tabs.
Settings examples are split by the following where appropriate:
The CSS change is the difference between a tab header being rendered like this:
and
I'm not entirely sure the correct wording for tab headers, so if a more concise word is used, the CSS update could be reverted - I'm unsure if I edited the correct spot in the CSS - and didn't assess where else it might have had an impact.