-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Use tabs for meltano.yml vs meltano config or env #7765
Conversation
✅ Deploy Preview for meltano ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Change made for all blocks matching a pattern, putting this here in case I need to reuse it:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mjsqu!
Could you please split the "CONFIG" tab into a "CLI" and "ENV VAR" tab?
@sbalnojan what do you think of this change? I like it as it brings the focus to the YAML file. https://deploy-preview-7765--meltano.netlify.app/concepts/plugins#state-extra for example |
Just updated to add @WillDaSilva suggestion of splitting out 'env' into another tab. Also aligned all tab groups with the name |
@mjsqu I quite like that! I'm going to hit merge |
No description provided.