Remove add_related for TRANSFORMS #5957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
previously requested changes
May 31, 2022
Co-authored-by: Edgar R. M. <edgar@meltano.com>
kgpayne
changed the title
kgpayne
changed the title
added 2 commits
June 1, 2022 20:20
…no/meltano into 3330-disable-auto-add-transformers
|
@kgpayne - This looks very close, with the one exception of some commented-out code snippet and a TODO marker. What's left to do here and do we need to hand off or can you get the remainder complete? |
This was referenced Jun 2, 2022
✅ Deploy Preview for meltano canceled.
|
added 6 commits
June 5, 2022 11:51
kgpayne
requested review from
tayloramurphy,
a team,
aaronsteers and
pandemicsyn
as code owners
kgpayne
dismissed
edgarrmondragon’s stale review
Changes apply to outdated commit
edgarrmondragon
approved these changes
Jun 5, 2022
|
I've resolved the merge conflict by re-locking poetry. |
aaronsteers
reviewed
Jun 5, 2022
Comment on lines
-50
to
-54
| @click.option( | ||
| "--include-related", | ||
| is_flag=True, | ||
| help="Also add transform plugins related to the identified discoverable extractor.", | ||
| ) |
There was a problem hiding this comment.
TODO: We may want to call out in migration docs somewhere that the --include-related CLI arg is removed from meltano add.
aaronsteers
reviewed
Jun 5, 2022
aaronsteers
reviewed
Jun 5, 2022
aaronsteers
reviewed
Jun 5, 2022
aaronsteers
approved these changes
Jun 5, 2022
msardana94
added a commit
to msardana94/meltano
that referenced
this pull request
Apr 18, 2023
I believe `--include-related` is deprecated in 2.0.0 as mentioned in meltano#5957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr:
As a side effect, this now allows a Transform plugin to be added to a project with an adapter-specific dbt install. However using an adapter-specific dbt with existing Transforms will fail due to a missing
DBT_SOURCE_SCHEMAenv var that was present as a setting in the legacy 'dbt' Transformer plugin definition but is not included in the new adapter-specific Transformer definitions. This should be addressed in a future issue if we wish to support the use of Transforms with adapter-specific dbt Transformers.