Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI exit event #6142

Merged
merged 8 commits into from Jun 10, 2022
Merged

Add CLI exit event #6142

merged 8 commits into from Jun 10, 2022

Conversation

WillDaSilva
Copy link
Member

@WillDaSilva WillDaSilva commented Jun 9, 2022

I've tested this manually using Snowplow Micro. We could add automated testing for it by checking if Meltano subprocesses that exit with various exit codes behave properly. We'll probably want to resolve #2955 prior to adding such tests, as otherwise actually verifying the behaviour will be tricky, regardless of whether it works or not.

(resolve is in backticks to stop GitHub from automatically closing #2955)

Closes #5986

@netlify
Copy link

netlify bot commented Jun 9, 2022

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit 8a92aaf
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/62a2b802e534f70008bbb995

@WillDaSilva WillDaSilva self-assigned this Jun 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #6142 (74c84f2) into main (c41c2c1) will decrease coverage by 0.04%.
The diff coverage is 36.36%.

❗ Current head 74c84f2 differs from pull request most recent head 0833aa1. Consider uploading reports for the commit 0833aa1 to get more accurate results

@@            Coverage Diff             @@
##             main    #6142      +/-   ##
==========================================
- Coverage   90.65%   90.60%   -0.05%     
==========================================
  Files         267      267              
  Lines       18732    18750      +18     
==========================================
+ Hits        16982    16989       +7     
- Misses       1750     1761      +11     
Impacted Files Coverage Δ
src/meltano/cli/__init__.py 38.23% <25.00%> (-7.60%) ⬇️
src/meltano/core/tracking/tracker.py 82.71% <50.00%> (-1.70%) ⬇️
tests/meltano/cli/test_elt.py 98.64% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c41c2c1...0833aa1. Read the comment docs.

Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small changes requested.

If no other major changes, you can merge after those (and after your own testing).

If other large factors are changed/added, please let me know and I'll do another review round.

src/meltano/cli/__init__.py Outdated Show resolved Hide resolved
src/meltano/core/tracking/tracker.py Outdated Show resolved Hide resolved
Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

* Centralize schema constants into `meltano.core.tracking.schemas`

* Add `IgluSchema` dataclass
@WillDaSilva
Copy link
Member Author

Apologies for merging #6146 into this. I forgot that it wasn't targeting main.

@WillDaSilva WillDaSilva merged commit fa6c148 into main Jun 10, 2022
@WillDaSilva WillDaSilva deleted the exit-event branch June 10, 2022 03:56
@aaronsteers
Copy link
Contributor

Apologies for merging #6146 into this. I forgot that it wasn't targeting main.

@WillDaSilva - not a problem. It happens.

I like what you updated there so it shouldn't be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect process exit events with Snowplow
3 participants