Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Interactive config for plugins with no settings #6891

Merged
merged 4 commits into from Oct 17, 2022

Conversation

WillDaSilva
Copy link
Member

Closes #6890

@WillDaSilva WillDaSilva requested a review from a team October 17, 2022 15:59
@WillDaSilva WillDaSilva self-assigned this Oct 17, 2022
@netlify
Copy link

netlify bot commented Oct 17, 2022

Deploy Preview for meltano ready!

Name Link
🔨 Latest commit 0a30308
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/634d97a9038cda00083ce5a7
😎 Deploy Preview https://deploy-preview-6891--meltano.netlify.app/getting-started/installation
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #6891 (dc3238c) into main (cfc4b3c) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head dc3238c differs from pull request most recent head 0a30308. Consider uploading reports for the commit 0a30308 to get more accurate results

@@            Coverage Diff             @@
##             main    #6891      +/-   ##
==========================================
- Coverage   88.73%   88.70%   -0.03%     
==========================================
  Files         283      283              
  Lines       20453    20423      -30     
  Branches     2016     2012       -4     
==========================================
- Hits        18149    18117      -32     
- Misses       1969     1971       +2     
  Partials      335      335              
Impacted Files Coverage Δ
src/meltano/cli/interactive/config.py 29.62% <0.00%> (-0.65%) ⬇️
tests/meltano/core/test_project_init_service.py 87.87% <0.00%> (-3.96%) ⬇️
src/meltano/core/project_init_service.py 96.20% <0.00%> (-1.33%) ⬇️
src/meltano/cli/initialize.py 77.14% <0.00%> (-1.24%) ⬇️
tests/meltano/cli/test_initialize.py 100.00% <0.00%> (ø)
src/meltano/cli/utils.py 83.80% <0.00%> (+1.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WillDaSilva WillDaSilva marked this pull request as ready for review October 17, 2022 16:40
@aaronsteers
Copy link
Contributor

@WillDaSilva, @tayloramurphy, @sbalnojan - I added a link which will render at:

The content there can change over time but I wanted to get this included so we are directing users to specific set of resources for this problem.

@WillDaSilva WillDaSilva enabled auto-merge (squash) October 17, 2022 18:04
@WillDaSilva WillDaSilva merged commit bbf4c9c into main Oct 17, 2022
@WillDaSilva WillDaSilva deleted the fix-interactive-config-no-settings branch October 17, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Can't configure freshdesk-tap
2 participants