New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cloud CLI for adding projects #7620
Conversation
Codecov Report
@@ Coverage Diff @@
## cloud #7620 +/- ##
========================================
Coverage ? 90.33%
========================================
Files ? 283
Lines ? 20851
Branches ? 2311
========================================
Hits ? 18836
Misses ? 1666
Partials ? 349 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Edgar R. M. <edgar@meltano.com>
Co-authored-by: Edgar R. M. <edgar@meltano.com>
@kgpayne can we get a docs update with this as well? |
https://github.com/meltano/infra/issues/514#issuecomment-1544941319 @kgpayne As @magreenbaum explains in the linked comment, merging this now would likely cause us some trouble in the not too distant future. I think it'd be best if we hold off on merging this until the API is ready to create the project specific resources, as otherwise I suspect we'll have some manual clean up work to do later, and some non-functional projects now. |
@magreenbaum is the backend API ready for this PR? |
@tayloramurphy No. It's waiting on this infra issue: |
@pnadolny13 would you mind doing some UAT on this? |
@cjohnhanson we'll need an update to https://docs.meltano.com/cloud/onboarding#prereq-2-provide-access-to-your-repo for this as well. I'm ok to do that in a separate, fast-follow PR, but can you make an issue and cross-link? |
@tayloramurphy I personally wasnt able to get a project created. I ran the example from the docs changes, I got a successful response but no project was created. I check in the UI and with a CLI list and I dont see any projects I tried to create.
It wasnt clear to met how the repo url should be passed, originally I used https://github.com/meltano/squared but then I noticed in the docs changes that it was https://github.com/meltano/squared.git with the |
Looks like this PR needs some more polish. @WillDaSilva are we blocked until @cjohnhanson returns from his OOO? |
@tayloramurphy Yes, unless you would rather someone else be assigned to get this over the finish line. |
@pnadolny13 @tayloramurphy -- sorry about that. Somewhere along the way in addressing PR feedback and merging in the latest updates from |
@cjohnhanson I was successfully able to create the project using the example command that Pat shared. Will you create a separate PR to update the onboarding guide with the new instructions for adding a project? https://docs.meltano.com/cloud/onboarding#step-2-login-to-meltano-cloud I did run into:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving but we need an update to the onboarding docs
LGTM |
Closes #7412