Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cloud CLI for adding projects #7620

Merged
merged 58 commits into from Aug 22, 2023
Merged

feat: Cloud CLI for adding projects #7620

merged 58 commits into from Aug 22, 2023

Conversation

kgpayne
Copy link
Contributor

@kgpayne kgpayne commented Apr 27, 2023

Closes #7412

@kgpayne kgpayne linked an issue Apr 27, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (cloud@5a300bf). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             cloud    #7620   +/-   ##
========================================
  Coverage         ?   90.33%           
========================================
  Files            ?      283           
  Lines            ?    20851           
  Branches         ?     2311           
========================================
  Hits             ?    18836           
  Misses           ?     1666           
  Partials         ?      349           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgpayne kgpayne marked this pull request as ready for review May 4, 2023 11:04
Co-authored-by: Edgar R. M. <edgar@meltano.com>
@tayloramurphy
Copy link
Collaborator

@kgpayne can we get a docs update with this as well?

@WillDaSilva
Copy link
Member

https://github.com/meltano/infra/issues/514#issuecomment-1544941319

@kgpayne As @magreenbaum explains in the linked comment, merging this now would likely cause us some trouble in the not too distant future. I think it'd be best if we hold off on merging this until the API is ready to create the project specific resources, as otherwise I suspect we'll have some manual clean up work to do later, and some non-functional projects now.

@kgpayne kgpayne marked this pull request as draft May 15, 2023 13:49
@kgpayne kgpayne self-assigned this May 15, 2023
@tayloramurphy
Copy link
Collaborator

@magreenbaum is the backend API ready for this PR?

@WillDaSilva
Copy link
Member

is the backend API ready for this PR?

@tayloramurphy No. It's waiting on this infra issue:

@cjohnhanson cjohnhanson requested review from sbalnojan and a team as code owners August 11, 2023 17:30
@tayloramurphy
Copy link
Collaborator

@pnadolny13 would you mind doing some UAT on this?

@tayloramurphy
Copy link
Collaborator

@cjohnhanson we'll need an update to https://docs.meltano.com/cloud/onboarding#prereq-2-provide-access-to-your-repo for this as well. I'm ok to do that in a separate, fast-follow PR, but can you make an issue and cross-link?

@pnadolny13
Copy link
Contributor

@pnadolny13 would you mind doing some UAT on this?

@tayloramurphy I personally wasnt able to get a project created. I ran the example from the docs changes, I got a successful response but no project was created. I check in the UI and with a CLI list and I dont see any projects I tried to create.

meltano-cloud project create --name pat-test2 --repo-url https://github.com/meltano/squared.git --root-path "data/"

⠋ Creating project - this may take several minutes...2023-08-14 09:58:29 [debug    ] Making Cloud CLI HTTP request  method=POST url=https://internal.api.meltano.cloud/projects/v1/01GV0Z1VW5TSRF8BYX1J2V3WNT
Project 'pat-test2' created successfully.

It wasnt clear to met how the repo url should be passed, originally I used https://github.com/meltano/squared but then I noticed in the docs changes that it was https://github.com/meltano/squared.git with the .git suffix. Either way I wasnt able to get a project to show up but I'm still not sure which is right or if both are accepted.

@tayloramurphy
Copy link
Collaborator

Looks like this PR needs some more polish. @WillDaSilva are we blocked until @cjohnhanson returns from his OOO?

@WillDaSilva
Copy link
Member

@tayloramurphy Yes, unless you would rather someone else be assigned to get this over the finish line.

@cjohnhanson
Copy link
Contributor

@pnadolny13 @tayloramurphy -- sorry about that. Somewhere along the way in addressing PR feedback and merging in the latest updates from cloud I unintentionally removed the statement which makes the actual signed request to the provisioner API. I've re-added the missing statements.

@tayloramurphy
Copy link
Collaborator

@cjohnhanson I was successfully able to create the project using the example command that Pat shared.

Will you create a separate PR to update the onboarding guide with the new instructions for adding a project? https://docs.meltano.com/cloud/onboarding#step-2-login-to-meltano-cloud

I did run into:

Copy link
Collaborator

@tayloramurphy tayloramurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but we need an update to the onboarding docs

@tayloramurphy
Copy link
Collaborator

LGTM :shipit:

@cjohnhanson cjohnhanson merged commit 5da0e84 into cloud Aug 22, 2023
44 checks passed
@cjohnhanson cjohnhanson deleted the kgpayne/issue7412 branch August 22, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud CLI to register a new project in Meltano Cloud
6 participants