-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expand environment variables in array setting values #8268
Conversation
✅ Deploy Preview for meltano canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8268 +/- ##
=======================================
Coverage 90.92% 90.93%
=======================================
Files 244 244
Lines 19272 19277 +5
Branches 2171 2173 +2
=======================================
+ Hits 17524 17529 +5
Misses 1425 1425
Partials 323 323 ☔ View full report in Codecov by Sentry. |
This exactly fits my current case where I have data coming from several environments - all with the same format. As a result I should be able to use the same pipeline without duplicating it. Releasing this fix would assist me hugely, and many others I'm sure. |
d280ecf
to
0eca111
Compare
0eca111
to
ed63e9c
Compare
✅ Deploy Preview for meltano canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to use t.Sequence
instead of list
, but even without that change I'm very happy to see this change. Thanks @edgarrmondragon! (and sorry for taking so long to review it!)
Co-authored-by: @WillDaSilva
@WillDaSilva that makes sense 👍 Thanks for reviewing! |
Closes #3171