Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expand environment variables in array setting values #8268

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

Closes #3171

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit 0eca111
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/656a8d1c2b02740008b0fc1c

@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 13, 2023 20:25
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be3976b) 90.92% compared to head (ed63e9c) 90.93%.
Report is 1 commits behind head on main.

❗ Current head ed63e9c differs from pull request most recent head 5d77e4f. Consider uploading reports for the commit 5d77e4f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8268   +/-   ##
=======================================
  Coverage   90.92%   90.93%           
=======================================
  Files         244      244           
  Lines       19272    19277    +5     
  Branches     2171     2173    +2     
=======================================
+ Hits        17524    17529    +5     
  Misses       1425     1425           
  Partials      323      323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ian-lewis-d
Copy link

This exactly fits my current case where I have data coming from several environments - all with the same format. As a result I should be able to use the same pipeline without duplicating it.

Releasing this fix would assist me hugely, and many others I'm sure.

@edgarrmondragon edgarrmondragon changed the title fix: Expand enviroment variables in array setting values feat: Expand environment variables in array setting values Dec 2, 2023
Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit 5d77e4f
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/656e4a86b2fb3d000880c4c3

Copy link
Member

@WillDaSilva WillDaSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to use t.Sequence instead of list, but even without that change I'm very happy to see this change. Thanks @edgarrmondragon! (and sorry for taking so long to review it!)

@edgarrmondragon
Copy link
Collaborator Author

We may want to use t.Sequence instead of list, but even without that change I'm very happy to see this change. Thanks @edgarrmondragon! (and sorry for taking so long to review it!)

@WillDaSilva that makes sense 👍

Thanks for reviewing!

@edgarrmondragon edgarrmondragon added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit f2358d3 Dec 4, 2023
47 checks passed
@edgarrmondragon edgarrmondragon deleted the fix/expand-array-values branch December 4, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested config values in setting arrays and objects don't have environment variables expanded
3 participants