Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added a include_callsite_parameters argument to the builtin log formatters, which adds source path, line number and function name fields to the emitted log #8494

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: Added a include_callsite_parameters argument to the builtin log formatters, which adds source path, line number and function name fields to the emitted log #8494

wants to merge 4 commits into from

Commits on Jun 19, 2024

  1. feat: Added a include_callsite_parameters argument to the builtin l… 

    …og formatters, which adds source path, line number and function name fields to the emitted log

Example usage:

```yaml
formatters:
  json: # log format for json formatted logs
    (): meltano.core.logging.json_formatter
    include_callsite_parameters: true
```

It can also be passed to the
`meltano.core.logging.console_log_formatter` and `meltano.core.logging.key_value_formatter` formatters.

https://www.structlog.org/en/stable/api.html#structlog.processors.CallsiteParameterAdder
    @edgarrmondragon
    edgarrmondragon committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    e94edac View commit details
    Browse the repository at this point in the history

  2. Add processor to structlog logs

    @edgarrmondragon
    edgarrmondragon committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    96f092a View commit details
    Browse the repository at this point in the history

  3. Update integration test

    @edgarrmondragon
    edgarrmondragon committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    b909781 View commit details
    Browse the repository at this point in the history

  4. Update another integration test

    @edgarrmondragon
    edgarrmondragon committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    a1dad70 View commit details
    Browse the repository at this point in the history