Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Changed references of Airflow orchestrator to utility #8524

Merged
merged 2 commits into from
May 1, 2024
Merged

docs: Changed references of Airflow orchestrator to utility #8524

merged 2 commits into from
May 1, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

Closes #7804

@edgarrmondragon edgarrmondragon linked an issue Apr 30, 2024 that may be closed by this pull request
bug: Getting Started uses airflow orchestrator instead of airflow utility #7804
Closed
@netlify Netlify
Copy link

netlify bot commented Apr 30, 2024 •
edited
Loading

✅ Deploy Preview for meltano ready!

Name Link
🔨 Latest commit 07dacfd
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/6631646c42d2160008a611ec
😎 Deploy Preview https://deploy-preview-8524--meltano.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@edgarrmondragon edgarrmondragon added the Documentation Improvements or additions to documentation label Apr 30, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review April 30, 2024 20:25
@edgarrmondragon edgarrmondragon marked this pull request as draft April 30, 2024 20:43
@edgarrmondragon edgarrmondragon marked this pull request as ready for review April 30, 2024 21:36
@edgarrmondragon edgarrmondragon added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit 46fac0f May 1, 2024
6 checks passed
@edgarrmondragon edgarrmondragon deleted the 7804-bug-getting-started-uses-airflow-orchestrator-instead-of-airflow-utility branch May 1, 2024 02:02
@edgarrmondragon edgarrmondragon mentioned this pull request May 15, 2024
Open
@ilsaloving
Copy link

In that case, https://hub.meltano.com/orchestrators/airflow/ needs to be updated and/or removed, since that is how I got to this point.

@edgarrmondragon
Copy link
Collaborator Author

In that case, https://hub.meltano.com/orchestrators/airflow/ needs to be updated and/or removed, since that is how I got to this point.

It's hidden on search, i.e. you only see the utility if you start typing "airflow" in the search box.

What we could do is show a banner warning that the orchestrator is deprecated: meltano/hub#1764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillDaSilva WillDaSilva WillDaSilva approved these changes

@sbalnojan sbalnojan Awaiting requested review from sbalnojan

@tayloramurphy tayloramurphy Awaiting requested review from tayloramurphy tayloramurphy is a code owner

Assignees
No one assigned
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Getting Started uses airflow orchestrator instead of airflow utility
3 participants
@edgarrmondragon @ilsaloving @WillDaSilva