Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update some type annotations in settings code #8557

Merged
merged 2 commits into from
May 28, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented May 23, 2024

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit a60ac22
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/6655061940f6c90008be1ff2

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.81%. Comparing base (7129516) to head (a60ac22).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8557   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files         245      245           
  Lines       19296    19296           
  Branches     2152     2152           
=======================================
  Hits        17717    17717           
  Misses       1306     1306           
  Partials      273      273           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/chore/settings-store-type-fixes branch from 858194b to 4175f31 Compare May 24, 2024 16:33
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/chore/settings-store-type-fixes branch from 4175f31 to fd6645e Compare May 27, 2024 14:58
@edgarrmondragon edgarrmondragon marked this pull request as ready for review May 27, 2024 21:28
@edgarrmondragon edgarrmondragon requested review from a team and WillDaSilva as code owners May 27, 2024 21:28
@edgarrmondragon edgarrmondragon added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit effdf0b May 28, 2024
50 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/chore/settings-store-type-fixes branch May 28, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants