Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mappers): Add datetime functions to simpleeval env in stream maps #1175

Merged

Conversation

qbatten
Copy link
Contributor

@qbatten qbatten commented Nov 11, 2022

Closes #986

This adds the datetime module to the simpleeval environment, similarly to how an md5 function was added. This enables datetime handling/processing in streammaps.


馃摎 Documentation preview 馃摎: https://meltano-sdk--1175.org.readthedocs.build/en/1175/

@qbatten qbatten force-pushed the 986-feat-add-datetime-to-streammaps branch from 920c780 to a225a8b Compare November 11, 2022 19:45
@edgarrmondragon edgarrmondragon changed the title feat(streammaps): Add datetime function to simpleeval env in streammaps feat(mappers): Add datetime function to simpleeval env in streammaps Nov 11, 2022
@edgarrmondragon edgarrmondragon changed the title feat(mappers): Add datetime function to simpleeval env in streammaps feat(mappers): Add datetime function to simpleeval env in stream maps Nov 11, 2022
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #1175 (a225a8b) into main (80daef2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1175   +/-   ##
=======================================
  Coverage   83.58%   83.58%           
=======================================
  Files          42       42           
  Lines        3874     3874           
  Branches      657      657           
=======================================
  Hits         3238     3238           
  Misses        473      473           
  Partials      163      163           

馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon changed the title feat(mappers): Add datetime function to simpleeval env in stream maps feat(mappers): Add datetime functions to simpleeval env in stream maps Nov 11, 2022
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @qbatten!

This is a great first contribution 馃憤

@edgarrmondragon edgarrmondragon merged commit 338b79a into meltano:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Datetime handling in streammaps
2 participants