Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mappers): Add datetime functions to simpleeval env in stream maps #1175

Merged
merged 1 commit into from
Nov 11, 2022
Merged

feat(mappers): Add datetime functions to simpleeval env in stream maps #1175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/stream_maps.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,8 @@ can be referenced directly by mapping expressions.
of the hash's hex digest.
- This is defined by the SDK internally with native python:
`hashlib.md5(<input>.encode("utf-8")).hexdigest()`.
- `datetime` - This is the datetime module object from the Python standard library. You can access
datetime.datetime, datetime.timedelta, etc.

#### Built-in Variable Names

Expand Down
2 changes: 2 additions & 0 deletions singer_sdk/mapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

import abc
import copy
import datetime
import hashlib
import logging
from typing import Any, Callable
Expand Down Expand Up @@ -292,6 +293,7 @@ def functions(self) -> dict[str, Callable]:
"""
funcs: dict[str, Any] = simpleeval.DEFAULT_FUNCTIONS.copy()
funcs["md5"] = md5
funcs["datetime"] = datetime
return funcs

def _eval(
Expand Down
11 changes: 11 additions & 0 deletions tests/core/test_mapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ def sample_catalog_dict() -> dict:
Property("name", StringType),
Property("owner_email", StringType),
Property("description", StringType),
Property("description", StringType),
).to_dict()
foobars_schema = PropertiesList(
Property("the", StringType),
Expand Down Expand Up @@ -70,21 +71,25 @@ def sample_stream():
"name": "tap-something",
"owner_email": "sample1@example.com",
"description": "Comment A",
"create_date": "2019-01-01",
},
{
"name": "my-tap-something",
"owner_email": "sample2@example.com",
"description": "Comment B",
"create_date": "2020-01-01",
},
{
"name": "target-something",
"owner_email": "sample3@example.com",
"description": "Comment C",
"create_date": "2021-01-01",
},
{
"name": "not-atap",
"owner_email": "sample4@example.com",
"description": "Comment D",
"create_date": "2022-01-01",
},
],
"foobars": [
Expand All @@ -107,6 +112,7 @@ def transform_stream_maps():
"email_hash": "md5(config['hash_seed'] + owner_email)",
"description": "'[masked]'",
"description2": "str('[masked]')",
"create_year": "int(datetime.date.fromisoformat(create_date).year)",
"int_test": "int('0')",
"__else__": None,
},
Expand All @@ -125,6 +131,7 @@ def transformed_result(stream_map_config):
),
"description": "[masked]",
"description2": "[masked]",
"create_year": 2019,
"int_test": 0,
},
{
Expand All @@ -135,6 +142,7 @@ def transformed_result(stream_map_config):
),
"description": "[masked]",
"description2": "[masked]",
"create_year": 2020,
"int_test": 0,
},
{
Expand All @@ -145,6 +153,7 @@ def transformed_result(stream_map_config):
),
"description": "[masked]",
"description2": "[masked]",
"create_year": 2021,
"int_test": 0,
},
{
Expand All @@ -155,6 +164,7 @@ def transformed_result(stream_map_config):
),
"description": "[masked]",
"description2": "[masked]",
"create_year": 2022,
"int_test": 0,
},
],
Expand All @@ -174,6 +184,7 @@ def transformed_schemas():
Property("email_hash", StringType),
Property("description", StringType),
Property("description2", StringType),
Property("create_year", IntegerType),
Property("int_test", IntegerType),
).to_dict(),
"foobars": PropertiesList(
Expand Down