Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support deselecting streams by default #1672

Merged
merged 5 commits into from
May 9, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented May 5, 2023

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #1672 (24d197e) into main (1ba86b3) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1672      +/-   ##
==========================================
+ Coverage   85.07%   85.11%   +0.04%     
==========================================
  Files          59       59              
  Lines        4864     4865       +1     
  Branches      807      806       -1     
==========================================
+ Hits         4138     4141       +3     
+ Misses        527      526       -1     
+ Partials      199      198       -1     
Impacted Files Coverage Δ
singer_sdk/_singerlib/catalog.py 98.14% <ø> (ø)
singer_sdk/streams/core.py 83.05% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon
Copy link
Collaborator Author

Surprisingly, test coverage didn't drop but I still want to add a few test cases

@edgarrmondragon
Copy link
Collaborator Author

@edgarrmondragon edgarrmondragon marked this pull request as ready for review May 8, 2023 19:08
@edgarrmondragon edgarrmondragon merged commit c2bea08 into main May 9, 2023
24 checks passed
@edgarrmondragon edgarrmondragon deleted the feat/selected-by-default branch May 9, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support de-selecting a stream by default
2 participants