Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Log stream errors #1686

Merged
merged 4 commits into from
May 23, 2023
Merged

feat: Log stream errors #1686

merged 4 commits into from
May 23, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented May 9, 2023

Before:

2023-05-09 11:48:49,576 | INFO     | sample-tap-countries | Beginning full_table sync of 'continents'...
2023-05-09 11:48:49,576 | INFO     | sample-tap-countries | Tap has custom mapper. Using 1 provided map(s).
{"type": "SCHEMA", "stream": "continents", "schema": {"properties": {"code": {"type": ["null", "string"]}, "name": {"type": ["null", "string"]}}, "type": "object"}, "key_properties": ["code"]}
2023-05-09 11:48:49,576 | INFO     | singer_sdk.metrics   | METRIC: {"type": "timer", "metric": "sync_duration", "value": 1.9073486328125e-05, "tags": {"stream": "continents", "context": {}, "status": "failed"}}
2023-05-09 11:48:49,576 | INFO     | singer_sdk.metrics   | METRIC: {"type": "counter", "metric": "record_count", "value": 0, "tags": {"stream": "continents", "context": {}}}
Traceback (most recent call last):

After:

2023-05-09 11:47:25,201 | INFO     | sample-tap-countries | Beginning full_table sync of 'continents'...
2023-05-09 11:47:25,201 | INFO     | sample-tap-countries | Tap has custom mapper. Using 1 provided map(s).
{"type": "SCHEMA", "stream": "continents", "schema": {"properties": {"code": {"type": ["null", "string"]}, "name": {"type": ["null", "string"]}}, "type": "object"}, "key_properties": ["code"]}
2023-05-09 11:47:25,201 | INFO     | singer_sdk.metrics   | METRIC: {"type": "timer", "metric": "sync_duration", "value": 1.5974044799804688e-05, "tags": {"stream": "continents", "context": {}, "status": "failed"}}
2023-05-09 11:47:25,201 | INFO     | singer_sdk.metrics   | METRIC: {"type": "counter", "metric": "record_count", "value": 0, "tags": {"stream": "continents", "context": {}}}
2023-05-09 11:47:25,201 | ERROR    | sample-tap-countries | An unhandled error occurred while syncing 'continents'
Traceback (most recent call last):

📚 Documentation preview 📚: https://meltano-sdk--1686.org.readthedocs.build/en/1686/

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #1686 (1518708) into main (9f1a013) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1686      +/-   ##
==========================================
+ Coverage   85.11%   85.12%   +0.01%     
==========================================
  Files          59       59              
  Lines        4878     4882       +4     
  Branches      809      809              
==========================================
+ Hits         4152     4156       +4     
  Misses        527      527              
  Partials      199      199              
Impacted Files Coverage Δ
singer_sdk/streams/rest.py 86.84% <ø> (ø)
singer_sdk/streams/core.py 83.21% <100.00%> (+0.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review May 19, 2023 23:36
@edgarrmondragon edgarrmondragon merged commit 0bb5f35 into main May 23, 2023
@edgarrmondragon edgarrmondragon deleted the feat/log-stream-sync-errors branch May 23, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants