Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validate parsed/transformed record against schema message #1769

Merged
merged 7 commits into from
Jul 5, 2023

Conversation

kgpayne
Copy link
Contributor

@kgpayne kgpayne commented Jun 16, 2023

Closes #1147

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #1769 (b666c68) into main (efd9fb6) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head b666c68 differs from pull request most recent head 441a248. Consider uploading reports for the commit 441a248 to get more accurate results

@@            Coverage Diff             @@
##             main    #1769      +/-   ##
==========================================
- Coverage   86.35%   86.32%   -0.04%     
==========================================
  Files          59       59              
  Lines        4961     4971      +10     
  Branches      811      813       +2     
==========================================
+ Hits         4284     4291       +7     
- Misses        479      481       +2     
- Partials      198      199       +1     
Impacted Files Coverage Δ
singer_sdk/exceptions.py 100.00% <100.00%> (ø)
singer_sdk/sinks/core.py 84.90% <100.00%> (+0.49%) ⬆️
singer_sdk/target_base.py 91.16% <100.00%> (-1.37%) ⬇️
singer_sdk/testing/target_tests.py 94.33% <100.00%> (+0.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgpayne kgpayne changed the title feat: validate parsed/transformed record against schema feat: validate parsed/transformed record against schema message Jun 16, 2023
@kgpayne
Copy link
Contributor Author

kgpayne commented Jun 16, 2023

cc @visch

@edgarrmondragon edgarrmondragon changed the title feat: validate parsed/transformed record against schema message feat: Validate parsed/transformed record against schema message Jun 19, 2023
@kgpayne kgpayne enabled auto-merge (squash) July 5, 2023 10:34
@kgpayne kgpayne merged commit 77c3f90 into main Jul 5, 2023
21 checks passed
@kgpayne kgpayne deleted the kgpayne/validate-singer-record branch July 5, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: SQLTarget - Record missing key property should fail nicely
2 participants