fix: Target template should not reference tap_id
#1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1843 +/- ##
=======================================
Coverage 86.56% 86.56%
=======================================
Files 59 59
Lines 5000 5000
Branches 811 811
=======================================
Hits 4328 4328
Misses 476 476
Partials 196 196 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hmm there seems to be a bug in the latest release of Cookiecutter. I logged an issue cookiecutter/cookiecutter#1900. I'll try downgrading the version we use in CI. |
edgarrmondragon
changed the title
tap_id
edgarrmondragon
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://meltano-sdk--1843.org.readthedocs.build/en/1843/