Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Target template should not reference tap_id #1843

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

pnadolny13
Copy link
Contributor

@pnadolny13 pnadolny13 commented Jul 14, 2023

Unable to create file '.github/workflows/{% if cookiecutter.include_ci_files == 'GitHub' %}test.yml{%endif%}'
Error message: 'collections.OrderedDict object' has no attribute 'tap_id'

📚 Documentation preview 📚: https://meltano-sdk--1843.org.readthedocs.build/en/1843/

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #1843 (437308b) into main (3ea47a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1843   +/-   ##
=======================================
  Coverage   86.56%   86.56%           
=======================================
  Files          59       59           
  Lines        5000     5000           
  Branches      811      811           
=======================================
  Hits         4328     4328           
  Misses        476      476           
  Partials      196      196           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon
Copy link
Collaborator

Hmm there seems to be a bug in the latest release of Cookiecutter. I logged an issue cookiecutter/cookiecutter#1900.

I'll try downgrading the version we use in CI.

@edgarrmondragon edgarrmondragon requested a review from a team as a code owner July 14, 2023 21:04
@edgarrmondragon edgarrmondragon changed the title fix: target template references tap_id fix: Target template should not reference tap_id Jul 14, 2023
@edgarrmondragon edgarrmondragon merged commit 98fdb2e into main Jul 14, 2023
@edgarrmondragon edgarrmondragon deleted the fix_target_template branch July 14, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants