Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use parent datetime.datetime class in type conforming checks #2455

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented May 27, 2024

Copy link

codspeed-hq bot commented May 27, 2024

CodSpeed Performance Report

Merging #2455 will not alter performance

Comparing edgarrmondragon/chore/use-datetime-parent-type-conforming (f8aa17e) with main (0da98f5)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.18%. Comparing base (0da98f5) to head (f8aa17e).
Report is 133 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2455      +/-   ##
==========================================
- Coverage   89.18%   89.18%   -0.01%     
==========================================
  Files          54       54              
  Lines        4791     4790       -1     
  Branches      937      937              
==========================================
- Hits         4273     4272       -1     
  Misses        361      361              
  Partials      157      157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review May 27, 2024 21:30
@edgarrmondragon edgarrmondragon merged commit 8237ab4 into main May 27, 2024
35 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/chore/use-datetime-parent-type-conforming branch May 27, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant