Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable ISC Ruff checks #1499

Merged
merged 1 commit into from
Mar 15, 2023
Merged

chore: Enable ISC Ruff checks #1499

merged 1 commit into from
Mar 15, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Mar 15, 2023

Motivation for flake8-implicit-str-concat:

This is a plugin for the Python code-checking tool Flake8 to encourage correct string literal concatenation.

It looks for style problems like implicitly concatenated string literals on the same line (which can be introduced by the code-formatting tool Black), or unnecessary plus operators for explicit string literal concatenation.


📚 Documentation preview 📚: https://meltano-sdk--1499.org.readthedocs.build/en/1499/

> This is a plugin for the Python code-checking tool Flake8 to encourage correct string literal concatenation.
>
> It looks for style problems like implicitly concatenated string literals on the same line (which can be introduced by the code-formatting tool Black), or unnecessary plus operators for explicit string literal concatenation.
Copy link
Member

@WillDaSilva WillDaSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #1499 (b79e9f6) into main (c328272) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1499   +/-   ##
=======================================
  Coverage   85.50%   85.50%           
=======================================
  Files          57       57           
  Lines        4760     4760           
  Branches      813      813           
=======================================
  Hits         4070     4070           
  Misses        498      498           
  Partials      192      192           
Impacted Files Coverage Δ
singer_sdk/_singerlib/catalog.py 98.17% <ø> (ø)
singer_sdk/_singerlib/messages.py 97.61% <ø> (ø)
singer_sdk/_singerlib/schema.py 100.00% <ø> (ø)
singer_sdk/authenticators.py 65.76% <ø> (ø)
singer_sdk/configuration/_dict_config.py 100.00% <ø> (ø)
singer_sdk/connectors/sql.py 81.91% <ø> (ø)
singer_sdk/helpers/_catalog.py 72.00% <ø> (ø)
singer_sdk/helpers/_conformers.py 78.57% <ø> (ø)
singer_sdk/helpers/_flattening.py 72.72% <ø> (ø)
singer_sdk/helpers/_state.py 69.44% <0.00%> (ø)
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review March 15, 2023 20:52
@edgarrmondragon edgarrmondragon merged commit 86e3b37 into main Mar 15, 2023
@edgarrmondragon edgarrmondragon deleted the chore/enable-ruff-ISC branch March 15, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants