Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(targets)!: Default handling of ACTIVATE_VERSION messages to soft deletes and add new SQLConnector.delete_old_versions method #2105

Conversation

Copy link

codspeed-hq bot commented Dec 14, 2023

CodSpeed Performance Report

Merging #2105 will not alter performance

Comparing 2103-bug-activate_version-deletes-rows-inserted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set (a089fd1) with main (f914452)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f914452) 87.84% compared to head (a089fd1) 87.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2105      +/-   ##
==========================================
+ Coverage   87.84%   87.89%   +0.05%     
==========================================
  Files          60       60              
  Lines        4953     4958       +5     
  Branches     1007     1008       +1     
==========================================
+ Hits         4351     4358       +7     
  Misses        424      424              
+ Partials      178      176       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon changed the title fix(targets): Do not handle ACTIVATE_VERSION by doing hard deletes by default fix(targets): Default handling of ACTIVATE_VERSION messages to soft deletes Dec 15, 2023
@edgarrmondragon edgarrmondragon force-pushed the 2103-bug-activate_version-deletes-rows-inserted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set branch 7 times, most recently from 1e79f7a to 5c4483a Compare December 19, 2023 00:49
@edgarrmondragon edgarrmondragon changed the title fix(targets): Default handling of ACTIVATE_VERSION messages to soft deletes fix(targets): Default handling of ACTIVATE_VERSION messages to soft deletes and add new SQLConnector.delete_old_versions method Dec 19, 2023
@edgarrmondragon edgarrmondragon force-pushed the 2103-bug-activate_version-deletes-rows-inserted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set branch 4 times, most recently from 21ce0e9 to 580dde6 Compare December 19, 2023 15:16
@edgarrmondragon edgarrmondragon force-pushed the 2103-bug-activate_version-deletes-rows-inserted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set branch 2 times, most recently from a05c8af to f4539f5 Compare December 20, 2023 22:16
@edgarrmondragon edgarrmondragon force-pushed the 2103-bug-activate_version-deletes-rows-inserted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set branch from f4539f5 to 27caeb2 Compare December 20, 2023 22:26
@edgarrmondragon edgarrmondragon changed the title fix(targets): Default handling of ACTIVATE_VERSION messages to soft deletes and add new SQLConnector.delete_old_versions method fix(targets)!: Default handling of ACTIVATE_VERSION messages to soft deletes and add new SQLConnector.delete_old_versions method Dec 20, 2023
edgarrmondragon and others added 7 commits December 20, 2023 19:36
…ted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
…ted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
…ted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
…ted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
…ted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
…ted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
…ted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 10, 2024 19:36
@edgarrmondragon edgarrmondragon merged commit a79cff8 into main Jan 10, 2024
33 checks passed
@edgarrmondragon edgarrmondragon deleted the 2103-bug-activate_version-deletes-rows-inserted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set branch January 10, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: activate_version deletes rows inserted in earlier batches (and deletes despite hard_delete not being set)
1 participant