feat: Expose metric dictionary to make logging metrics as JSON easier #2162
+115
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2162 will not alter performanceComparing Summary
|
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/metrics-json-logging
branch
from
2c3ec58
to
815b748
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2162 +/- ##
=======================================
Coverage 89.18% 89.18%
=======================================
Files 54 54
Lines 4788 4791 +3
Branches 936 936
=======================================
+ Hits 4270 4273 +3
Misses 361 361
Partials 157 157 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/metrics-json-logging
branch
4 times, most recently
from
64e71fd
to
75dc465
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/metrics-json-logging
branch
3 times, most recently
from
8edd581
to
2125742
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/metrics-json-logging
branch
from
2125742
to
5add1e7
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/metrics-json-logging
branch
from
5add1e7
to
2f2cc7d
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/metrics-json-logging
branch
from
2f2cc7d
to
2d3bf56
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/metrics-json-logging
branch
from
2d3bf56
to
fe99021
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/metrics-json-logging
branch
from
fe99021
to
a80e01c
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/metrics-json-logging
branch
from
a80e01c
to
de62b92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://meltano-sdk--2162.org.readthedocs.build/en/2162/