fix(taps): update _flatten_record function by adding allow_nan=True in json.dumps #2214
Conversation
CodSpeed Performance ReportMerging #2214 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2214 +/- ##
=======================================
Coverage 88.47% 88.47%
=======================================
Files 54 54
Lines 4720 4720
Branches 919 919
=======================================
Hits 4176 4176
Misses 383 383
Partials 161 161 ☔ View full report in Codecov by Sentry. |
dgawlowsky
changed the title
| @@ -430,7 +430,7 @@ def _flatten_record( | |||
| items.append( | |||
| ( | |||
| new_key, | |||
| json.dumps(v, use_decimal=True, default=str) | |||
| json.dumps(v, use_decimal=True, default=str, allow_nan=True) | |||
There was a problem hiding this comment.
Wdyt about making this configurable with two initial NaN options (e.g. fail and allow)?
There was a problem hiding this comment.
I gave it a first try, please see move the conversation to #2222 and close this PR if possible.
Edit: I put a draft into the name of the PR as I am still refining the code.
There was a problem hiding this comment.
@edgarrmondragon can you take a look?
There was a problem hiding this comment.
@edgarrmondragon please close this PR and see the proposal in #2222
dgawlowsky
changed the title
dgawlowsky
changed the title
|
Closed in favor of #2222 |
Fix #2213
📚 Documentation preview 📚: https://meltano-sdk--2214.org.readthedocs.build/en/2214/