Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove upper constraint on urllib3 #2238

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Feb 13, 2024

Copy link

codspeed-hq bot commented Feb 13, 2024

CodSpeed Performance Report

Merging #2238 will not alter performance

Comparing edgarrmondragon/fix/remove-upper-constraint-urllib3 (ba8dd6c) with main (1d1afbe)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.98%. Comparing base (1d1afbe) to head (ba8dd6c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2238   +/-   ##
=======================================
  Coverage   88.98%   88.98%           
=======================================
  Files          54       54           
  Lines        4767     4767           
  Branches      926      926           
=======================================
  Hits         4242     4242           
  Misses        364      364           
  Partials      161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/remove-upper-constraint-urllib3 branch 2 times, most recently from 661fcb2 to 6d7cb00 Compare February 23, 2024 16:54
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/remove-upper-constraint-urllib3 branch from 6d7cb00 to 185b478 Compare March 20, 2024 22:58
@edgarrmondragon
Copy link
Collaborator Author

Anytime someone runs poetry lock it'll start causing problems, so I'm not sure if this is worth it...

@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/fix/remove-upper-constraint-urllib3 branch May 7, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant