feat: JSON schema keywords such as maxLength are now supported in StringType, IntegerType and NumberType JSON schema helpers
#2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2241 +/- ##
==========================================
+ Coverage 88.68% 88.76% +0.07%
==========================================
Files 54 54
Lines 4738 4769 +31
Branches 921 928 +7
==========================================
+ Hits 4202 4233 +31
Misses 374 374
Partials 162 162 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #2241 will not alter performanceComparing Summary
|
edgarrmondragon
force-pushed
the
edgarrmondragon/feat/jsonschema-string-numeric-keywords
branch
3 times, most recently
from
5c1241e
to
7ec1798
Compare
… number JSON schema helpers
edgarrmondragon
force-pushed
the
edgarrmondragon/feat/jsonschema-string-numeric-keywords
branch
from
7ec1798
to
8ac041d
Compare
edgarrmondragon
changed the title
maxLength and similar keywords in string, integer and number JSON schema helpersmaxLength are now supported in StringType, IntegerType and NumberType JSON schema helpers
edgarrmondragon
deleted the
edgarrmondragon/feat/jsonschema-string-numeric-keywords
branch
edgarrmondragon
added a commit
that referenced
this pull request
Mar 6, 2024
…StringType`, `IntegerType` and `NumberType` JSON schema helpers (#2241) feat: Support `maxLength` and similar keywords in string, integer and number JSON schema helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://meltano-sdk--2241.org.readthedocs.build/en/2241/