Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable Ruff preview rules #2369

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Apr 11, 2024

Copy link

codspeed-hq bot commented Apr 11, 2024

CodSpeed Performance Report

Merging #2369 will not alter performance

Comparing edgarrmondragon/chore/enable-ruff-preview-rules (e52037a) with main (acf7b28)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 98.63014% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.76%. Comparing base (acf7b28) to head (e52037a).

Files Patch % Lines
singer_sdk/authenticators.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2369   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files          54       54           
  Lines        4779     4779           
  Branches      930      930           
=======================================
  Hits         4242     4242           
  Misses        374      374           
  Partials      163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/chore/enable-ruff-preview-rules branch from 8e94e48 to e52037a Compare April 11, 2024 20:34
@edgarrmondragon edgarrmondragon marked this pull request as ready for review April 11, 2024 20:50
@edgarrmondragon edgarrmondragon requested a review from a team as a code owner April 11, 2024 20:50
@edgarrmondragon edgarrmondragon merged commit 8751f66 into main Apr 11, 2024
31 of 32 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/chore/enable-ruff-preview-rules branch April 11, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant