Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin edk to v0.1.0 #8

Merged
merged 4 commits into from
Feb 14, 2023
Merged

chore: pin edk to v0.1.0 #8

merged 4 commits into from
Feb 14, 2023

Conversation

pnadolny13
Copy link
Contributor

@pnadolny13 pnadolny13 commented Jan 24, 2023

Related to meltano/hub#1115

@pnadolny13 pnadolny13 changed the title pin edk to v0.1.0 chore: pin edk to v0.1.0 Jan 24, 2023
@pnadolny13
Copy link
Contributor Author

@edgarrmondragon @WillDaSilva any idea why this test is failing? It says models doesnt exist but looks like it does https://github.com/meltano/edk/blob/main/meltano/edk/models.py.

@edgarrmondragon
Copy link
Contributor

@edgarrmondragon @WillDaSilva any idea why this test is failing? It says models doesnt exist but looks like it does meltano/edk@main/meltano/edk/models.py.

@pnadolny13 I'll update mypy 🤞

Copy link
Contributor

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pnadolny13 Had to fix the import and EDK usage. This is g2g now, I think but I'd test it before 😅

@pnadolny13
Copy link
Contributor Author

@edgarrmondragon I actually cant get this working 🤔 although I'm not sure its related to this PR specifically, looking into it more

@edgarrmondragon
Copy link
Contributor

@pnadolny13 Any luck figuring out those failures?

@pnadolny13
Copy link
Contributor Author

@edgarrmondragon I havent had time to try again but when I tried last week I was getting failures going through the hub getting started steps when pointing to main so I didnt have a base case to tests this branch against.

@pnadolny13
Copy link
Contributor Author

@edgarrmondragon I confirmed this is good! I also found some bugs related to it and fixed them in meltano/hub#1169.

@pnadolny13 pnadolny13 merged commit 0bfe8b4 into main Feb 14, 2023
@pnadolny13 pnadolny13 deleted the pin_edk branch February 14, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants