-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
insert '@' and [space] when completing an @mention #158
Comments
that was my initial behavior. then I changed it to match Facebook's. up for discussion |
i think its fine the way it is (i'm used to how fb does it) |
I actually prefer with a space insert. Maybe we can try both and see which one seems more natural. |
i feel like FB's is better because they linkify and highlight the name as soon as you select it from the dropdown. we just insert normal looking text, so it feels a lot weirder. if you try github's which is a lot similar to ours. if you do @meltedxice or @pingpongboss it will insert the name (with the @ in front, and append the space for you. feels more natural typing this way) |
so what do u want calchat's to be like? Keep in mind that we can't do the highlighting because it's a technical challenge that I wont be able to solve any time soon |
yeah so my point is we should just follow github's form On Sat, Apr 14, 2012 at 6:43 PM, Mark Wei <
Jonathan |
oh ic yea that's simple enough. |
so currently when you do an @mention from the typeahead, it just inserts a persons name and also places the cursor at the end of the name, with no space.
a better behavior would probably be to insert: @FIRST L(space) so the user can keep typing his/her chat fluidly. ive caught myself typing an @reply really fast and then having to backspace to add a space in between the @mention and the message text
The text was updated successfully, but these errors were encountered: