Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert '@' and [space] when completing an @mention #158

Closed
ricefield opened this issue Apr 13, 2012 · 7 comments
Closed

insert '@' and [space] when completing an @mention #158

ricefield opened this issue Apr 13, 2012 · 7 comments
Assignees

Comments

@ricefield
Copy link
Collaborator

so currently when you do an @mention from the typeahead, it just inserts a persons name and also places the cursor at the end of the name, with no space.

a better behavior would probably be to insert: @FIRST L(space) so the user can keep typing his/her chat fluidly. ive caught myself typing an @reply really fast and then having to backspace to add a space in between the @mention and the message text

@pingpongboss
Copy link
Collaborator

that was my initial behavior. then I changed it to match Facebook's. up for discussion

@0xjessel
Copy link
Owner

i think its fine the way it is (i'm used to how fb does it)

@pingpongboss
Copy link
Collaborator

I actually prefer with a space insert. Maybe we can try both and see which one seems more natural.

@ricefield
Copy link
Collaborator Author

i feel like FB's is better because they linkify and highlight the name as soon as you select it from the dropdown. we just insert normal looking text, so it feels a lot weirder.

if you try github's which is a lot similar to ours. if you do @meltedxice or @pingpongboss it will insert the name (with the @ in front, and append the space for you. feels more natural typing this way)

@pingpongboss
Copy link
Collaborator

so what do u want calchat's to be like? Keep in mind that we can't do the highlighting because it's a technical challenge that I wont be able to solve any time soon

@ricefield
Copy link
Collaborator Author

yeah so my point is we should just follow github's form

On Sat, Apr 14, 2012 at 6:43 PM, Mark Wei <
reply@reply.github.com

wrote:

so what do u want calchat's to be like? Keep in mind that we can't do the
highlighting because it's a technical challenge that I wont be able to
solve any time soon


Reply to this email directly or view it on GitHub:
#158 (comment)

Jonathan

@pingpongboss
Copy link
Collaborator

oh ic yea that's simple enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants