Using typed array instead of native JS array #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great find, thanks! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation uses native JS arrays for store layers image data. But JS arrays is very inefficient for store large binary data. I replaced them with Uint8Array. It is supported by all modern browsers as well as by NodeJS. It provides significant performance gain.
I used following psd file for testing https://drive.google.com/open?id=1LgGiHPgbr9Vrc7j0DCvXDSlFBBk5AmB5
Original version in my PC is trying to allocate about 1.5 GB of RAM and then it die with "JavaScript heap out of memory" error. See also the issue #135
My version uses less than 400 MB of RAM and it loads file successfully.
I have to apologize but this PR also contains code for my previous PR #117 that isn't merged yet. But in my project I need both ability to work with mask data and working with large PSD files (100 MB and more) so I cannot easlty separate them