Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mocha #228

Merged
merged 1 commit into from
Sep 25, 2021
Merged

Update mocha #228

merged 1 commit into from
Sep 25, 2021

Conversation

MgenGlder
Copy link
Collaborator

@MgenGlder MgenGlder commented Sep 25, 2021 •
edited
Loading

Summary

Background

  • We want any major security issues to be resolved moving forward, our mocha is extremely out of date and has many critical and high vulnerabilities (see issue)- we can fix this quickly with an update to latest on mocha.

Acceptance

  • Make sure that everything still works.

@MgenGlder MgenGlder self-assigned this Sep 25, 2021
@MgenGlder MgenGlder added the dependencies Pull requests that update a dependency file label Sep 25, 2021
@MgenGlder
Copy link
Collaborator Author

@fabulousduck going to go ahead and merge this one as well. Tested the npm run test command with your added test and didn't see anything act strangely or unexpectedly. To the moon! 🚀

@MgenGlder MgenGlder merged commit 5e3af88 into master Sep 25, 2021
@MgenGlder MgenGlder linked an issue Sep 25, 2021 that may be closed by this pull request
Bumping lodash version to maintain security #224
Closed
@MgenGlder MgenGlder removed a link to an issue Sep 25, 2021
Bumping lodash version to maintain security #224
Closed
@MgenGlder MgenGlder linked an issue Sep 25, 2021 that may be closed by this pull request
Update Mocha to latest to resolve security vulnerability #227
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabulousduck fabulousduck Awaiting requested review from fabulousduck

Assignees

@MgenGlder MgenGlder

Labels
dependencies Pull requests that update a dependency file
Projects
Update all Dependencies w/ Security V...
Awaiting triage
Milestone
Remove Security Vulnerabilities
Development

Successfully merging this pull request may close these issues.

Update Mocha to latest to resolve security vulnerability
1 participant
@MgenGlder