Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/signature checking #96

Merged
merged 4 commits into from
Jul 14, 2017

Conversation

fabulousduck
Copy link
Collaborator

No description provided.

@fabulousduck
Copy link
Collaborator Author

fabulousduck commented Jul 11, 2017

I opted to not add a test for this as it is a tiny change and it tested this manually.
@meltingice whats your opinion on straight up throwing an error ?
Do you prefer this method, or would you rather it not throw one and return an error string or something like that ?

this solves #90

@fabulousduck
Copy link
Collaborator Author

#96 changed the package which i also did by trying out tests with chai in this branch. Fixed now and can be merged without conflicts.

@meltingice meltingice merged commit 0c6a46d into meltingice:master Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants