Skip to content
This repository has been archived by the owner on Jun 11, 2019. It is now read-only.

Janitor deletes data only containers and images #18

Closed
Mrono opened this issue Mar 9, 2016 · 5 comments
Closed

Janitor deletes data only containers and images #18

Mrono opened this issue Mar 9, 2016 · 5 comments

Comments

@Mrono
Copy link

Mrono commented Mar 9, 2016

I had to re-create my entire environment

@mikljohansson
Copy link
Contributor

Very sorry to hear that!

The first sentence of the readme does say "This image will periodically clean up exited containers and remove images and volumes that aren't in use by a running container." but that might not be enough. Perhaps we should include more of a warning like https://github.com/chadoe/docker-cleanup-volumes does, highlighting what the container will do?

@Mrono
Copy link
Author

Mrono commented Mar 9, 2016

It happens, not upset.

I installed via the rancher catalog, which may not have that warning (still my fault for not investigating it more). The issue is that the cleanup doesn't make a distinction between stopped containers, and stopped data-only containers.

@mikljohansson
Copy link
Contributor

I've added a warning in bold text to the readme, let's hope others don't end up with the same issues.

When using exited containers to hold data I think this cleanup image might not be the best thing to have running in a cluster, even if carefully excluding them with $KEEP_CONTAINERS. Since it could be prone to mistakes and wipe out valuable data.

Didn't know that this image was in rancher catalog, is that a curated repository and where could I find it? (Google didn't help much in finding it..)

About data-only containers, is there a way to distinguish them from regular existed containers?

@Mrono
Copy link
Author

Mrono commented Mar 9, 2016

@mikljohansson
Copy link
Contributor

Interesting, will take a closer look. In any case, thanks for reporting this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants