Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #121

Merged
merged 5 commits into from May 26, 2020
Merged

Fix tests #121

merged 5 commits into from May 26, 2020

Conversation

pastushenkoy
Copy link
Contributor

@pastushenkoy pastushenkoy commented May 25, 2020 •
edited

Please read CONTRIBUTING.md for details on our code of conduct, and the process for submitting pull requests to us.

Fixes #120

Proposed Changes

Description

Specifies exact version of GCS mock in order to keep tests green.

Checklist

  • Read the CONTRIBUTING document.
  • Read the CODE OF CONDUCT document.
  • Add tests to cover changes.
  • Ensure your code follows the code style of this project.
  • Ensure CI and all other PR checks are green OR
    • Code compiles correctly.
    • Created tests which fail without the change (if possible).
    • All new and existing tests passed.
  • Add your changes to Unreleased section of CHANGELOG.
  • Improve and update the README (if necessary).
  • Ensure documentation is up-to-date. The same file will be updated in plugin index when your PR is accepted, so it will be available for end-users at http://plugins.drone.io.

@pastushenkoy
Copy link
Contributor Author

@kakkoyun Can you help me with the build? I can't get what it wants.

@kakkoyun
Copy link
Contributor

@pastushenkoy It's totally unrelated to your changes. I have fixed the master. Please rebase and it should be all good.

@pastushenkoy
Copy link
Contributor Author

I'm afraid I already got the latest changes in my master branch.

kakkoyun
kakkoyun reviewed May 26, 2020
View reviewed changes
CHANGELOG.md Outdated
@@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixes [#88](https://github.com/meltwater/drone-cache/issues/88).
- [#86](https://github.com/meltwater/drone-cache/pull/86) Fixed rebuild errors when a nested path given in mount.
- Fixes [#87](https://github.com/meltwater/drone-cache/issues/87).
- [120](https://github.com/meltwater/drone-cache/pull/121)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need a changelog entry for this one. Just external dependency update for tests.

@kakkoyun
Copy link
Contributor

I've forgotten to push. Now it's fixed and your branch is up-to-date. If you would address the comment then we can go ahead and merge it. Thanks a lot for fixing it 😄

@pastushenkoy
Copy link
Contributor Author

Seems like it's done? )

kakkoyun
kakkoyun approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@kakkoyun kakkoyun merged commit a1c231f into meltwater:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

@limayekaiwalya limayekaiwalya Awaiting requested review from limayekaiwalya

@seandtaber seandtaber Awaiting requested review from seandtaber seandtaber is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New version of gcs fake breaks tests
2 participants
@pastushenkoy @kakkoyun