Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle commits with '--allow-empty' #46

Merged
merged 1 commit into from
Feb 9, 2021
Merged

handle commits with '--allow-empty' #46

merged 1 commit into from
Feb 9, 2021

Conversation

jimsheldon
Copy link
Contributor

empty commits should not cause pipelines or pipeline steps to be excluded
if a trigger or path exclude is set

handle commits with '--allow-empty'
ed0e46c 
empty commits should not cause pipelines or pipeline steps to be excluded
if a trigger or path exclude is set
@jimsheldon jimsheldon mentioned this pull request Feb 5, 2021
Closed
tychedelia
tychedelia approved these changes Feb 5, 2021
View reviewed changes
Copy link

@tychedelia tychedelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much for taking care of this so quickly. Feel confident with the inclusion of test that this will cover our scenario. :)

@jimsheldon jimsheldon merged commit f4b3840 into master Feb 9, 2021
@jimsheldon jimsheldon deleted the handle-empty-commits branch February 9, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tychedelia tychedelia tychedelia approved these changes

@apoorva-marisomaradhya apoorva-marisomaradhya apoorva-marisomaradhya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jimsheldon @tychedelia @apoorva-marisomaradhya