Close channels explicitly

meltwater · Nov 19, 2018 · 1a3a6fb · 1a3a6fb
1 parent 5d545c5
commit 1a3a6fb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/lib/consumer.ex b/lib/consumer.ex
@@ -287,9 +287,11 @@ defmodule GenRMQ.Consumer do
 
   @doc false
   @impl GenServer
-  def terminate(reason, %{module: module, conn: conn}) do
+  def terminate(reason, %{module: module, conn: conn, in: in_chan, out: out_chan}) do
     Logger.debug("[#{module}]: Terminating consumer, reason: #{inspect(reason)}")
-    AMQP.Connection.close(conn)
+    Channel.close(in_chan)
+    Channel.close(out_chan)
+    Connection.close(conn)
   end
 
   ##############################################################################

diff --git a/lib/publisher.ex b/lib/publisher.ex
@@ -144,9 +144,10 @@ defmodule GenRMQ.Publisher do
 
   @doc false
   @impl GenServer
-  def terminate(reason, %{module: module, conn: conn}) do
+  def terminate(reason, %{module: module, conn: conn, channel: channel}) do
     Logger.debug("[#{module}]: Terminating publisher, reason: #{inspect(reason)}")
-    AMQP.Connection.close(conn)
+    Channel.close(channel)
+    Connection.close(conn)
   end
 
   ##############################################################################