Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Upgrade amqp to version 1.0.3 #22

Merged
merged 9 commits into from Jul 2, 2018
Merged

Upgrade amqp to version 1.0.3 #22

merged 9 commits into from Jul 2, 2018

Conversation

mkorszun
Copy link
Collaborator

Description

Checklist

  • I have added unit tests to cover my changes.
  • I have improved the code quality of this repo. (refactoring, or reduced number of static analyser issues)
  • I have updated the documentation accordingly

@mkorszun mkorszun requested a review from vorce as a code owner June 26, 2018 09:08
@mkorszun mkorszun mentioned this pull request Jun 26, 2018
3 tasks
@soundmonster
Copy link
Contributor

I'm trying to upgrade to this version to test it with one of our phoenix apps, but it seems like latest Phoenix and amqp 1.0.x series conflict on ranch:

Failed to use "ranch" (version 1.3.2) because
  amqp (versions 1.0.0 to 1.0.3) requires ~> 1.4
  cowboy (version 1.1.2) requires ~> 1.3.2
  mix.lock specifies 1.3.2

Phoenix seems to need cowboy to be 1.x.x (latest is 1.1.2), but it specifies ranch 1.3.2.

Have you managed to make it work in a Phoenix app yet?

@vorce
Copy link
Collaborator

vorce commented Jun 26, 2018

@soundmonster have you tried specifying ranch 1.4 in mix.exs and setting override: true on it?

@soundmonster
Copy link
Contributor

I'll try, thank you! It seems like Phoenix 1.4 will support Cowboy 2.3, and this in turn depends on ranch 1.4, so maybe we could wait for that.

Copy link
Contributor

@soundmonster soundmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked, works for me now.

@vorce
Copy link
Collaborator

vorce commented Jun 26, 2018

@soundmonster what did you do? Was it the override: true thing? If so we might want to mention it in the upgrade section of the README in this PR @mkorszun

@mkorszun
Copy link
Collaborator Author

@soundmonster @vorce yes, definitely will have to mention it. Will also check with couple of phoenix apps we have.

@soundmonster
Copy link
Contributor

yep, the override: true thing with ranch 1.4

@mkorszun
Copy link
Collaborator Author

@soundmonster have you managed to silence lager as well?

@soundmonster
Copy link
Contributor

soundmonster commented Jun 26, 2018

yes, that worked! I've just used the snippet from your readme, reformatted it like this:

# Disable lager (transitive dependency via gen_rmq)
config :lager,
  crash_log: false,
  handlers: [level: :critical],
  error_logger_redirect: false,
  error_logger_whitelist: [Logger.ErrorHandler]

@vorce
Copy link
Collaborator

vorce commented Jun 26, 2018

That's nicer formatted for sure :D

@mkorszun
Copy link
Collaborator Author

mkorszun commented Jun 27, 2018

@vorce would you mind having a look at recent updates, especially at https://github.com/meltwater/gen_rmq/wiki/Migrations?

@vorce
Copy link
Collaborator

vorce commented Jun 27, 2018

Done @mkorszun LGTM - just made some small copy changes to the migrations wiki page.

@mkorszun mkorszun merged commit 644dd32 into master Jul 2, 2018
@mkorszun mkorszun deleted the upgrade-amqp1.0 branch July 2, 2018 08:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants