Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing param and return types in Chroma and Qdrant vector stores #1688

Closed
NavyaAlapati13 opened this issue Aug 12, 2024 · 2 comments · Fixed by #1689
Closed

Missing param and return types in Chroma and Qdrant vector stores #1688

NavyaAlapati13 opened this issue Aug 12, 2024 · 2 comments · Fixed by #1689
Assignees
Labels
enhancement New feature or request

Comments

@NavyaAlapati13
Copy link
Contributor

NavyaAlapati13 commented Aug 12, 2024

🚀 The feature

The Qdrant and Chroma vector store files are missing parameter types and return types for the functions. It's a non breaking change which will increase code clairty.

Motivation, pitch

To increase the code readabliliy and clarity, and maintain coding standards.

@NavyaAlapati13
Copy link
Contributor Author

I will share a PR soon for this.
@Dev-Khant can you please assign me this issue?

@Dev-Khant
Copy link
Collaborator

Hey @NavyaAlapati13 thanks for picking this up! I'll assign it to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants