Minor fixe and support for tcmalloc #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport for libmemcached
|
awesome, thanks! |
cb-robot
pushed a commit
that referenced
this pull request
Sep 21, 2015
…race. Write of size 8 at 0x7d040000f5d0 by main thread: #0 free <null>:0 #1 tzset_internal #2 ISOTime::generatetimestamp(std::array<char, 33ul>&, long, unsigned int) #3 ISOTime::generatetimestamp() #4 Audit::create_audit_event(unsigned int, cJSON*) #5 shutdown_auditdaemon #6 main Previous write of size 8 at 0x7d040000f5d0 by thread T4 (mutexes: write M775): #0 malloc <null>:0 #1 __GI___strdup #2 ISOTime::generatetimestamp(std::array<char, 33ul>&, long, unsigned int) #3 ISOTime::generatetimestamp() #4 put_json_audit_event #5 audit_invalid_packet crtstuff.c:0 #6 process_bin_packet(Connection*) #7 Connection::runStateMachinery() #8 run_event_loop #9 event_handler(int, short, void*) #10 event_base_loop <null>:0 #11 platform_thread_wrap This is triggered by our use of mktime in isotime.cc. We're not the first to encounter this and suppress it. https://code.google.com/p/chromium/issues/detail?id=78014 http://src.chromium.org/svn/trunk/src/tools/valgrind/tsan/suppressions.txt?p=115967 Change-Id: I8cb46e085adc0d18230bd51eebf2195ed1a5c453 Reviewed-on: http://review.couchbase.org/55393 Reviewed-by: Dave Rigby <daver@couchbase.com> Tested-by: buildbot <build@couchbase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling from source, memcachetest always fail because it can't find the memcached binary. It's easy to fix by adding the proper option.
I also added a switch to support compilation with tcmalloc.