Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds detection of duplicated operation Ids #16

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

carnage
Copy link
Contributor

@carnage carnage commented Jun 8, 2023

No description provided.

Copy link
Collaborator

@charjr charjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not related specifically to this PR but we might want to consider putting $operationId = $operationObject->operationId in the RouteCollector as we're calling that property quite a few times

@charjr charjr merged commit 85af736 into main Jun 8, 2023
20 checks passed
@charjr charjr deleted the ensure-unique-operationids branch June 8, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants