This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Mv 317 add 404 page #150
Merged
Mv 317 add 404 page #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ostatni5
commented
Mar 2, 2023
•
ostatni5
commented
- Add 404 page in ui
- Redirect all unknown paths to ui
ostatni5
force-pushed
the
MV-317-add-404-page
branch
2 times, most recently
from
72222ea
to
df666d4
Compare
ostatni5
force-pushed
the
MV-317-add-404-page
branch
from
df666d4
to
7102fcb
Compare
ostatni5
force-pushed
the
MV-317-add-404-page
branch
from
c5a2140
to
7556046
Compare
ostatni5
force-pushed
the
MV-317-add-404-page
branch
from
7a9e477
to
f82b7e3
Compare
kamil-stasiak
approved these changes
Mar 7, 2023
bblaszkow06
reviewed
Mar 7, 2023
assets/tailwind.config.js
Outdated
Comment on lines
29
to
34
| inset: { | ||
| ...generateFractionPercentages(20), | ||
| }, | ||
| height: { | ||
| ...generateFractionPercentages(10), | ||
| }, |
There was a problem hiding this comment.
Why do we need to generate this? Isn't the arbitrary values syntax enough in that case?
There was a problem hiding this comment.
You are right. Arbitrary values are good enough. I didn't notice that syntax when I was working on it.
bblaszkow06
approved these changes
Mar 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.