This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Mv 309 implement vad on core 0 11 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkrucz00
force-pushed
the
MV-309-implement-vad-core-0-11
branch
from
30bdaa4
to
95492f0
Compare
pkrucz00
force-pushed
the
MV-309-implement-vad-core-0-11
branch
from
95492f0
to
cec06d5
Compare
pkrucz00
changed the title
bblaszkow06
changed the base branch from
master
to
MV-351-migrate-to-deps-using-core
pkrucz00
force-pushed
the
MV-309-implement-vad-core-0-11
branch
from
cec06d5
to
d0a4ec9
Compare
* Debounce and litte css animation * Change dependency to a different branch
bblaszkow06
approved these changes
May 12, 2023
mix.exs
Outdated
Comment on lines
36
to
38
| :membrane_rtp_plugin, | ||
| # path: "../membrane_rtp_plugin", | ||
| github: "membraneframework/membrane_rtp_plugin", branch: "master", override: true |
There was a problem hiding this comment.
Obviously, we should wait with merge for the released versions
There was a problem hiding this comment.
It can be deleted altogether. Including only membrane_rtc_engine should be suffiecent since it depends on rtp_plugin. I've overlooked it and will change it immediately.
bblaszkow06
approved these changes
May 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch changes the dependencies so the RTP_plugin uses the branch where the new VAD algorithm is being proposed.
The PR for the aforementioned functionality can be found here