This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Mv 379 improper horizontal #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblaszkow06
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Looks fine to me, but wait for @kamil-stasiak's approval before merging.
kamil-stasiak
suggested changes
Apr 13, 2023
Co-authored-by: Kamil Stasiak <kamilstasiaknew@gmail.com>
kamil-stasiak
approved these changes
Apr 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pull Request aims to make the "Ooops, trn your device... " screen a little more accurate in terms of when it should pop out.
The proposed solution is that we check if a device is a smartphone (not a tablet - tablets should behave like desktops in terms of most UI) by:
MAX_MOBILE_WIDTH_BANDWIDTHand then check if he screen is horizontal.The behaviour of the "Turn your device..." screen works as expected on most smartphones and tablets tested on chrome devtools. There may be some uncovered cases like a laptop with touchscreen and small viewport (eg. when minimising the width of a window). Those should be tested as well.
Besides, some small readability changes have been done..