This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
[MV-463] Internals: limit large strings #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
approved these changes
Jun 5, 2023
pkrucz00
force-pushed
the
MV-463-internals-limit-large-strings
branch
from
6c025b2
to
54072fe
Compare
bblaszkow06
changed the title
bblaszkow06
approved these changes
Jun 5, 2023
| <Details key={name} className="pl-4" summaryText={name}> | ||
| <ul> | ||
| {values.map((v, idx) => ( | ||
| <li className="px-4" key={`${idx}:${v}`}> |
There was a problem hiding this comment.
I'd reduce the font size as SDPs are quite long
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing the sdp answer and offer as a string.
Displays the sdp offer or answer after clicking the display element.
The lines are displayed with their positional number.
I don't know if the parsing is good and if the numbers in front of lines should be the line numbers. Please, @mickel8 , take a look.