Multiple elements in one process (#293) #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblaszkow06
force-pushed
the
293-multiple-elems-one-process
branch
from
94e6811
to
bca1121
Compare
bblaszkow06
force-pushed
the
293-multiple-elems-one-process
branch
from
3c2d4bf
to
aa70341
Compare
bblaszkow06
force-pushed
the
293-multiple-elems-one-process
branch
from
e1166ce
to
75d4a6b
Compare
mat-hek
requested changes
May 16, 2022
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
bblaszkow06
force-pushed
the
293-multiple-elems-one-process
branch
from
afbea4f
to
8d80c2a
Compare
mat-hek
previously approved these changes
May 30, 2022
mat-hek
reviewed
May 30, 2022
lib/membrane/filter_aggregator.ex
Outdated
|
|
||
| {name, module} -> | ||
| unless is_atom(module) and module.membrane_element?() do | ||
| raise "#{inspect(module)} is not an element!" |
There was a problem hiding this comment.
Let's raise something more like https://github.com/membraneframework/membrane_core/blob/master/lib/membrane/core/parent/child_entry_parser.ex#L53
There was a problem hiding this comment.
Do you mean the message, exception type or both?
I've started to write it as a ParentError but I realized it might not be the best idea to treat FilterAggregator as a parent in that scenario. I've used ArgumentError instead as it's passed via options and raise happens on handle_init. Any thoughts on that?
mat-hek
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #293