Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added log metadata when reporting init #376

Merged
merged 5 commits into from Jan 7, 2022
Merged

Conversation

Qizot
Copy link
Member

@Qizot Qizot commented Jan 3, 2022

The purpose of this PR is to add logger's metadata when reporting events such as init/terminate so that the element being created/terminated can be more easily distinguished beside having the already existing component's path, or so that it will carry arbitrary information necessary helpful for further processing.

lib/membrane/core/pipeline.ex Outdated Show resolved Hide resolved
@Qizot Qizot changed the title Added log metadata when reporting init/terminate Added log metadata when reporting init Jan 5, 2022
Copy link
Contributor

@andpodob andpodob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Qizot Qizot merged commit 82d6162 into master Jan 7, 2022
@Qizot Qizot deleted the telemetry-logger-metadata branch January 7, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants