Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when bin removes its pad #554

Merged
merged 2 commits into from May 12, 2023
Merged

Fix bug when bin removes its pad #554

merged 2 commits into from May 12, 2023

Conversation

FelonEkonom
Copy link
Member

@FelonEkonom FelonEkonom added the no-changelog This label has to be added if changes from the PR are not meant to be placed in the CHANGELOG.md label May 11, 2023
@FelonEkonom FelonEkonom requested a review from mat-hek as a code owner May 11, 2023 15:19
@FelonEkonom @mat-hek
Update lib/membrane/core/bin/pad_controller.ex
7bd67de 
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
@FelonEkonom FelonEkonom requested a review from mat-hek May 11, 2023 15:46
@FelonEkonom FelonEkonom merged commit e8278aa into master May 12, 2023
7 checks passed
@FelonEkonom FelonEkonom deleted the removing-pad-bug-fix branch May 12, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-hek mat-hek mat-hek approved these changes

Assignees
No one assigned
Labels
no-changelog This label has to be added if changes from the PR are not meant to be placed in the CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FelonEkonom @mat-hek