Stop calling handle_demand after end of stream #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
added
the
no-changelog
This reverts commit dd01b9e.
FelonEkonom
force-pushed
the
fix-handle-demand-bug
branch
from
e15599e
to
89614d4
Compare
mat-hek
requested changes
Jun 20, 2023
| when action not in [:latency, :notify_parent] do | ||
| raise ActionError, action: action, reason: {:invalid_callback, :handle_init} | ||
| def handle_action(action, callback, params, state) do | ||
| state = Map.update!(state, :callback_depth_counter, &(&1 + 1)) |
There was a problem hiding this comment.
instead of that, I'd set a handling_callback? flag in the callback handler
| @@ -25,6 +25,9 @@ defmodule Membrane.Core.Element.ActionHandlerTest do | |||
| playback: :stopped, | |||
| synchronization: %{clock: nil, parent_clock: nil}, | |||
| delayed_demands: MapSet.new(), | |||
| callback_depth_counter: 0, | |||
| pads_to_snapshot: MapSet.new(), | |||
| pads_to_snapshot: MapSet.new(), | |||
There was a problem hiding this comment.
Suggested change
| pads_to_snapshot: MapSet.new(), |
FelonEkonom
force-pushed
the
fix-handle-demand-bug
branch
from
94ba8e4
to
9d339b8
Compare
mat-hek
approved these changes
Jun 20, 2023
| reraise e, __STACKTRACE__ | ||
| end | ||
| end) | ||
| old_handling_action? = state.handling_action? |
There was a problem hiding this comment.
Suggested change
| old_handling_action? = state.handling_action? | |
| was_handling_action? = state.handling_action? |
| @@ -25,6 +25,9 @@ defmodule Membrane.Core.Element.ActionHandlerTest do | |||
| playback: :stopped, | |||
| synchronization: %{clock: nil, parent_clock: nil}, | |||
| delayed_demands: MapSet.new(), | |||
| callback_depth_counter: 0, | |||
| pads_to_snapshot: MapSet.new(), | |||
| pads_to_snapshot: MapSet.new(), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira ticket: https://membraneframework.atlassian.net/browse/MC-204