Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Ratio to 4.0.1 #780

Merged
merged 3 commits into from Mar 26, 2024
Merged

Bump Ratio to 4.0.1 #780

merged 3 commits into from Mar 26, 2024

Conversation

FelonEkonom
Copy link
Member

No description provided.

@FelonEkonom FelonEkonom self-assigned this Mar 19, 2024
mix.exs Outdated
@@ -144,7 +144,7 @@ defmodule Membrane.Mixfile do
{:qex, "~> 0.3"},
{:telemetry, "~> 1.0"},
{:bunch, "~> 1.6"},
{:ratio, "~> 3.0"},
{:ratio, ">= 4.0.1 and < 5.0.0"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an equivalent of "~>> 4.0.1". However, I think it should be

Suggested change
{:ratio, ">= 4.0.1 and < 5.0.0"},
{:ratio, "~> 3.0 or ~>> 4.0.1"},

so it doesn't block updating plugins that depend on ratio

@FelonEkonom FelonEkonom merged commit ef91c4d into master Mar 26, 2024
5 of 6 checks passed
@FelonEkonom FelonEkonom deleted the ratio-4.0.1 branch March 26, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants