Develop #1
Merged
Develop #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblaszkow06
force-pushed
the
develop
branch
9 times, most recently
from
01f71e0
to
d2b3dee
Compare
H264 encoder requires time_base to be set
mat-hek
requested changes
Oct 26, 2018
| end | ||
|
|
||
| state = %{state | partial_frame: ""} | ||
| {{:ok, buffer: {:output, bufs}, event: {:output, %EndOfStream{}}}, state} |
There was a problem hiding this comment.
Notify the pipeline about the EoS
| def handle_event(:input, %EndOfStream{}, _ctx, state) do | ||
| with {:ok, frames} <- Native.flush(state.encoder_ref), | ||
| bufs <- wrap_frames(frames) do | ||
| {{:ok, bufs ++ [event: {:output, %EndOfStream{}}]}, state} |
There was a problem hiding this comment.
Notify the pipeline about the EoS
mat-hek
requested changes
Oct 31, 2018
| Membrane element that decodes video in H264 format. It is backed by decoder from FFmpeg. | ||
|
|
||
| The element expects the data for each frame (Access Unit) to be received in a separate buffer, | ||
| so the parser (`Membrane.Element.RawVideo.Parser`) may be required in a pipeline before |
| Membrane element that encodes raw video frames to H264 format. | ||
|
|
||
| The element expects each frame to be received in a separate buffer, so the parser | ||
| (`Membrane.Element.FFmpeg.H264.Parser`) may be required in a pipeline before |
| @@ -83,20 +97,20 @@ defmodule Membrane.Element.FFmpeg.H264.Encoder do | |||
| with {:ok, frames} <- Native.encode(payload, encoder_ref), | |||
| bufs <- wrap_frames(frames), | |||
| in_caps <- ctx.pads.input.caps do | |||
There was a problem hiding this comment.
The two last clauses should be moved out of with
mat-hek
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.