Adjust to precompiled dependencies API of bundlex #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
requested changes
Sep 4, 2023
bundlex.exs
Outdated
Comment on lines
28
to
30
| os_deps: [ | ||
| {get_ffmpeg(), ["libavcodec", "libswresample", "libavutil"]} | ||
| ], |
There was a problem hiding this comment.
Instead of having get_ffmpeg/0 function, create a function like
defp ffmpeg_os_deps(), do: [{get_ffmpeg(), ["libavcodec", "libswresample", "libavutil"]}]to avoid repeating yourself.
If you decide to still have a function with body of get_ffmpeg/0, I would suggest to rename it to something like get_ffmpeg_url/0
mix.exs
Outdated
| {:unifex, "~> 1.1"}, | ||
| {:membrane_core, "~> 0.12.0"}, | ||
| {:membrane_core, "~> 0.12.7"}, |
There was a problem hiding this comment.
We have already released v0.12.8 of membrane_core 😜
mat-hek
reviewed
Sep 11, 2023
bundlex.exs
Outdated
| @@ -12,19 +27,25 @@ defmodule Membrane.H264.FFmpeg.BundlexProject do | |||
| parser: [ | |||
| interface: :nif, | |||
| sources: ["parser.c"], | |||
| pkg_configs: ["libavcodec", "libavutil"], | |||
| os_deps: [ | |||
| {[get_ffmpeg(), :pkg_config], ["libavcodec", "libswresample", "libavutil"]} | |||
Noarkhh
force-pushed
the
use_precompiled_deps
branch
from
c5826bf
to
4b03485
Compare
FelonEkonom
approved these changes
Oct 6, 2023
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjust the bundlex configuration to the new API allowing for precompiled specification.